New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade packages with pur #4124

Merged
merged 1 commit into from Jun 7, 2018

Conversation

Projects
None yet
3 participants
@humitos
Member

humitos commented May 22, 2018

$ pur --skip django-tastypie,django,docker-py,elasticsearch,pyelasticsearch,commonmark,stripe,djangorestframework,mkdocs,django-allauth

Closes #4125

Upgrade packages with pur
$ pur --skip django-tastypie,django,docker-py,elasticsearch,pyelasticsearch,commonmark,stripe,djangorestframework,mkdocs,django-allauth

@humitos humitos self-assigned this May 22, 2018

@agjohnson agjohnson added this to the Cleanup milestone May 22, 2018

@humitos humitos requested a review from rtfd/core May 23, 2018

@@ -74,7 +71,7 @@ django-formtools==2.1
# docker is pinned to 3.1.3 because we found some strange behavior
# related to timeouts on EXEC with 3.2.1 that's not present with 3.1.3
# https://github.com/rtfd/readthedocs.org/issues/3999
docker==3.1.3
docker==3.3.0

This comment has been minimized.

@ericholscher

ericholscher May 24, 2018

Member

Are we sure the above comment is fixed? I'm not sure upgrading all our dependencies all the time is the best way to ensure stability, sadly :/

This comment has been minimized.

@humitos

humitos May 24, 2018

Member

We don't.

I tested this locally and everything was working. Although, last time it happened the same, but the problem appeared only in production and we weren't able to reproduce locally.

I'm not sure how I can do a test this in production without breaking everything. Maybe just install this in one of the builders, test it and then undo it?

This comment has been minimized.

@ericholscher

ericholscher Jun 7, 2018

Member

I think hopefully it should be fixed. There isn't a great way to test in prod, other than to deploy it sadly. :/

@ericholscher ericholscher merged commit e9d349c into master Jun 7, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stsewd stsewd deleted the humitos/pur/update-packages branch Aug 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment