Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
oauth/services: don't abuse log.exception #4133
Thanks for your contribution.
I'm not sure I follow this change, though. When an unhandled exception happen, we want to log it with the whole traceback which is useful for debugging.
log.exceptions belongs to the clause
try/except/else which are valid.
Why do you think it's better to
log.error instead of
Because else is not for unhandled exceptions but for code that does not raise any exception: