New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small footer rework #4150

Merged
merged 6 commits into from May 30, 2018

Conversation

Projects
None yet
3 participants
@davidfischer
Contributor

davidfischer commented May 25, 2018

This reworks the footer specifically to:

  • Add an email newsletter signup form. Back in 2014 (see WayBack Machine) we had an email newsletter in the footer. It got way too much spam signups and would have cost us money to continue to use it. Our email newsletter is now "double opt-in" meaning not only do users have to type in an email address but they have to confirm their email address by receiving an email and clicking a confirm to sign up to the list. This should drastically reduce the spam signups and increase quality overall.
  • Balances the 3 footer columns a bit better
  • Centers the social media/github icons
  • The version number is on its own line. Previously this wrapped slightly awkwardly.

From a browser perspective, I tested this down to IE11.

SCREENSHOT

screen shot 2018-05-25 at 4 34 04 pm

@davidfischer davidfischer added the Design label May 25, 2018

@davidfischer davidfischer requested a review from rtfd/core May 25, 2018

@davidfischer

This comment has been minimized.

Contributor

davidfischer commented May 26, 2018

The CI errors are unrelated.

@ericholscher

This comment has been minimized.

Member

ericholscher commented May 29, 2018

I like this in general, a few comments:

  • It feels like the blog & newsletter should tie together more. They are effectively the same content, but here it feels like they are separate things
  • I'm not in love with centering the social icons. It makes it feel like a heading or something, instead of a section. Do we need icons for this?
  • I'm not sure about the "Read the Docs", "About Us" , and "Email Newsletter" headings. They feel weirdly disjoint in scope.

A proposal:

Stay Updated
------------

Blog
Twitter
Newsletter Sub Form

Get Involved
------------

Getting Started
Docs
Contributing
GitHub
Team
OSS Philosophy

Business Info
-------------

Advertise with Us
Private Hosting
Gold Supporters
Donate 
Privacy

I'm also not sold on keeping "Donate" around, now that we have real business things, it feels a bit disjoint. I think we should probably focus on where we want people to go (eg. less Commercial Support, more Private Hosting)

@humitos

This comment has been minimized.

Member

humitos commented May 29, 2018

I liked what you did, David and I agree with Eric about how to organize the content. Those 3 headings are clearer regarding what you a looking for.

Also, there are some changes like "Commercial Support" to "Private Hosting" that makes a difference to me.

Not sure about removing the "Donate" menu. I would keep it there, it doesn't force anybody to Donate, but if you feel like, you can find it there. The other way to find it is under your Admin settings in the Gold section: there is a link to sustainability page.

@davidfischer

This comment has been minimized.

Contributor

davidfischer commented May 29, 2018

I'm not in love with centering the social icons. It makes it feel like a heading or something, instead of a section. Do we need icons for this?

I like the icons but I'm willing to be overruled. I do think a github icon and a twitter icon is better than the word "GitHub" or "Twitter". It also gives us space to grow if we do more social media stuff although I don't think that's very important.

I'm also not sold on keeping "Donate" around

I'm willing to drop it.

Overall, I think the proposed organization makes sense.

davidfischer added some commits May 29, 2018

@davidfischer

This comment has been minimized.

Contributor

davidfischer commented May 29, 2018

I made the changes to the organization of the footer.

screen shot 2018-05-29 at 1 56 08 pm

Here's an updated screenshot. I still haven't removed the social icons as I want to make sure that's the path we want to take. Personally I like them but I'm willing to be overruled.

@davidfischer

This comment has been minimized.

Contributor

davidfischer commented May 29, 2018

Debatably "Team" should go under "Business Info". Also possibly "Business Info" should be simply "Business".

@ericholscher

I don't feel strongly enough about the social icons to veto them, so I'm happy with this direction.

</li>
</ul>
<p>{% trans 'Sign up for our newsletter to get our latest blog updates delivered to your inbox weekly.' %}</p>

This comment has been minimized.

@ericholscher

ericholscher May 30, 2018

Member

I might also link the blog here to the blog, and perhaps even more it from above. That might make it a bit more seemless.

@humitos

I like these changes. Too much clear and simplified from my point of view.

Regarding the icons, either way works to me.

@ericholscher ericholscher merged commit 7a12c2e into rtfd:master May 30, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment