New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CSS override that doesn't exist. #4165

Merged
merged 6 commits into from May 30, 2018

Conversation

Projects
None yet
3 participants
@ericholscher
Member

ericholscher commented May 30, 2018

Also remove static path file.

This also fixes a bug that was causing logging to not be happening in Sphinx. This now properly shows errors, so that we can fix them.

Remove CSS override that doesn't exist.
Also remove static path file,
and run our tests with warnings enabled since we can now.

@ericholscher ericholscher requested a review from stsewd May 30, 2018

@davidfischer

This comment has been minimized.

Contributor

davidfischer commented May 30, 2018

This was on my list so I'm glad you did it! 👍

@stsewd

stsewd approved these changes May 30, 2018

@@ -71,14 +71,11 @@
gettext_compact = False
html_theme = 'sphinx_rtd_theme'
html_static_path = ['_static']
#html_static_path = ['_static']

This comment has been minimized.

@stsewd

stsewd May 30, 2018

Member

A space after the #? Just being a little nitpick about the style p:

This comment has been minimized.

@ericholscher

ericholscher added some commits May 30, 2018

@ericholscher ericholscher merged commit f083818 into master May 30, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stsewd stsewd deleted the remove-css-override branch May 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment