New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some warnings on docs #4172

Merged
merged 4 commits into from May 31, 2018

Conversation

Projects
None yet
2 participants
@stsewd
Member

stsewd commented May 31, 2018

Related to #4166

@@ -21,11 +21,6 @@
.. automodule:: readthedocs.projects.models
:members:
:mod:`readthedocs.projects.search_indexes`

This comment has been minimized.

@stsewd

stsewd May 31, 2018

Member

This was removed in a cleanup (#4039)

@@ -102,7 +102,7 @@ Why do we collect this?
- We limit our use of your User Personal Information to the purposes listed in this Privacy Statement.
If we need to use your User Personal Information for other purposes, we will ask your permission first.
You can always see what information we have in your
`user account <https://readthedocs.org/accounts/edit/>`_.
`user account <https://readthedocs.org/accounts/edit/>`__.

This comment has been minimized.

@stsewd

stsewd May 31, 2018

Member

Using anonymous refs is recommended (lost the link for this statement :/, but it was on a sphinx issue)

@@ -19,7 +19,7 @@ class VersionManagerBase(models.Manager):
"""
Version manager for manager only queries.
For queries not suitable for the :py:cls:`VersionQuerySet`, such as create
For queries not suitable for the :py:class:`VersionQuerySet`, such as create

This comment has been minimized.

@stsewd

stsewd May 31, 2018

Member

Somewhere in the time this was renamed to :py:class: http://www.sphinx-doc.org/en/stable/domains.html#role-py:class

@ericholscher ericholscher merged commit 2bc6bd8 into rtfd:master May 31, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stsewd stsewd deleted the stsewd:remove-some-warnings branch May 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment