New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing gitignore item for ES testing #4193

Merged
merged 1 commit into from Jun 6, 2018

Conversation

Projects
None yet
2 participants
@ericholscher
Member

ericholscher commented Jun 6, 2018

No description provided.

@ericholscher ericholscher requested a review from safwanrahman Jun 6, 2018

@safwanrahman

This comment has been minimized.

Member

safwanrahman commented Jun 6, 2018

have you run the script locally?

@ericholscher

This comment has been minimized.

Member

ericholscher commented Jun 6, 2018

Yea, I ran it to get ES setup on the same version to test against :)

@safwanrahman

safwanrahman approved these changes Jun 6, 2018 edited

Looks cool! I had never run the script locally so could not catch this.
r+

@safwanrahman safwanrahman merged commit 9dbb768 into master Jun 6, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stsewd stsewd deleted the add-ignore branch Aug 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment