New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the max theme version #4195

Merged
merged 3 commits into from Jun 8, 2018

Conversation

Projects
None yet
3 participants
@davidfischer
Contributor

davidfischer commented Jun 6, 2018

This increases the minor version of the default theme version.

  • The big difference between 0.3.x theme versions and 0.4.x theme versions is that the CSS/JS is bundled with the theme in 0.4.x rather than relying on a single centralized version when built on Read the Docs (building locally is different). Not bundling resulted in version mismatches.
  • This should go out after #3968

@davidfischer davidfischer requested a review from rtfd/core Jun 6, 2018

@ericholscher

👍

@ericholscher

This comment has been minimized.

Member

ericholscher commented Jun 7, 2018

We need to fix the test that is checking for the specific version output.

@davidfischer

This comment has been minimized.

Contributor

davidfischer commented Jun 7, 2018

Correct. That's sort of a weird test but I'll get it resolved. I figure some people are pinned to the latest theme and if there are any issues (we haven't seen any) they'll report it. This can go out in a release next week sometime.

@agjohnson agjohnson merged commit 52fee2c into rtfd:master Jun 8, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment