New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed breaking change in pip 10.0.0b1 (2018-03-31) #4206

Merged
merged 2 commits into from Jun 18, 2018

Conversation

Projects
None yet
4 participants
@FlorianKuckelkorn
Contributor

FlorianKuckelkorn commented Jun 7, 2018

  • Fixed breaking change in pip 10.0.0b1 (2018-03-31)
  • "--use-wheel" was removed fro pip's cli
- Fixed breaking change in pip 10.0.0b1 (2018-03-31)
- "--use-wheel" was removed fro pip's cli
@stsewd

This comment has been minimized.

Member

stsewd commented Jun 7, 2018

Thanks! can you link to the changelog?

Also, rtd isn't using pip10 right now, it uses this docker images https://github.com/rtfd/readthedocs-docker-images

@FlorianKuckelkorn

This comment has been minimized.

Contributor

FlorianKuckelkorn commented Jun 7, 2018

Hi, that's my very first pull request on github :)
How do you want me to link it to the changelog, set a new version?

@stsewd

This comment has been minimized.

Member

stsewd commented Jun 7, 2018

Just put it in this issue. My second comment was about that rtd doesn't use pip10 yet, and for doing it, we need to update all the docker images from our side. So, probably this PR would be blocked till we update the pip version, or maybe both options can live together? (changelog is helpful here)

@FlorianKuckelkorn

This comment has been minimized.

Contributor

FlorianKuckelkorn commented Jun 7, 2018

Ok i got it ;)
Changelog of PIP 10.0.0.b1

Probably if we remove line complety it would work for all pip versions, i would guess...

@stsewd

This comment has been minimized.

Member

stsewd commented Jun 8, 2018

Blocking this till we update pip

@stsewd

This comment has been minimized.

Member

stsewd commented Jun 14, 2018

This flag was introduced in pip7 https://pip.pypa.io/en/stable/news/#id25, so it's not blocked, we can merge this.

Also, this fixes #4238

@stsewd stsewd removed the Status: blocked label Jun 14, 2018

@stsewd

stsewd approved these changes Jun 14, 2018

@ericholscher

This comment has been minimized.

Member

ericholscher commented Jun 18, 2018

👍

@ericholscher ericholscher merged commit b6de0c4 into rtfd:master Jun 18, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ericholscher

This comment has been minimized.

Member

ericholscher commented Jun 18, 2018

Thanks!

agjohnson added a commit that referenced this pull request Jun 18, 2018

Revert "Merge pull request #4206 from FlorianKuckelkorn/fix/pip-break…
…ing-change"

This reverts commit b6de0c4, reversing
changes made to 08beab1.

ericholscher added a commit that referenced this pull request Jun 19, 2018

Merge pull request #4261 from rtfd/agj/hotfix-pip10
Revert "Merge pull request #4206 from FlorianKuckelkorn/fix/pip-breaking-change"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment