New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default sphinx version #4250

Merged
merged 4 commits into from Jun 19, 2018

Conversation

Projects
None yet
3 participants
@stsewd
Member

stsewd commented Jun 15, 2018

@stsewd stsewd requested a review from rtfd/core Jun 15, 2018

@ericholscher

This comment has been minimized.

Member

ericholscher commented Jun 18, 2018

I wonder if we should just do <1.8?

@humitos

This comment has been minimized.

Member

humitos commented Jun 18, 2018

I'd like to have <1.8 but "you never know". Anyway, maybe instead of increasing the version when it breaks for some reason, we could decrease (or pin) when it breaks.

👍 on using <1.8

@@ -1152,7 +1152,7 @@ def test_install_core_requirements_sphinx(self):
requirements_sphinx = [
'commonmark==0.5.4',
'recommonmark==0.4.0',
'sphinx==1.7.5',
'sphinx<1.8',

This comment has been minimized.

@ericholscher

ericholscher Jun 18, 2018

Member

Feels like we shouldn't be checking for this in a test, as it makes it really brittle. Should we remove this test?

This comment has been minimized.

@ericholscher

ericholscher Jun 18, 2018

Member

Looking at it more, it looks like we should be checking for what we actually care about (eg. 'sphinx' in called_arguments not "check it called the exact versions from our code"

This comment has been minimized.

@stsewd

stsewd Jun 18, 2018

Member

That makes sense, should I change all the tests here?

This comment has been minimized.

@ericholscher

ericholscher Jun 18, 2018

Member

Sure. I think it's a small enough change to be fine.

stsewd added some commits Jun 18, 2018

@ericholscher ericholscher merged commit af22d27 into rtfd:master Jun 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ericholscher

This comment has been minimized.

Member

ericholscher commented Jun 19, 2018

👍

@stsewd stsewd deleted the stsewd:update-sphinx-version-1.7.5 branch Jun 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment