Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Move config.py from rtd build #4272
@stsewd so this might be where we need to be careful. It looks like the
formats has changed, but this would be backwards incompatible with our implied version 1 of the schema. I think before we make this change we should work out a pattern to support both v1 and v2. If we still support
formats: none, then this is not an issue though
Perhaps for now we should just port the code, get it running in RTD core, then start working out this pattern, then start porting in some of the backwards incompatible changes.
We probably still need to address
As long as the features are backwards compatible on v1, it's not a problem to support them in v1 i think.
mmm, do you mean this change rtfd/readthedocs-build#43? I thought it was already deployed. We already change the docs for that https://docs.readthedocs.io/en/latest/yaml-config.html#formats. Also, the value was never used in the rtd code. But it wasn't causing any error in both sides anyway. Should I keep the compatibility with
I'm confused why the test case works currently, but if we don't need
none in this list, then