New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap notifications HTML code into a block #4273

Merged
merged 1 commit into from Jun 21, 2018

Conversation

Projects
None yet
2 participants
@humitos
Member

humitos commented Jun 19, 2018

This block is override in error pages to be none and do not show notifications on these pages.

Related work in corporate site rtfd/readthedocs-corporate#356

Wrap notifications HTML code into a block
This block is override in error pages to be none and do not show
notifications on these pages.

@humitos humitos requested a review from rtfd/core Jun 19, 2018

@ericholscher

Simple enough 👍

@ericholscher ericholscher merged commit ae9d47c into master Jun 21, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@humitos humitos deleted the humitos/notifications/error-pages branch Jun 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment