New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean CC sensible data on Gold subscriptions #4291

Merged
merged 3 commits into from Sep 5, 2018

Conversation

Projects
None yet
3 participants
@humitos
Member

humitos commented Jun 22, 2018

PaymentView.submit_form function removes all CC sensible data.

This function is used for GoldView in this repo and also for
DonateView in -ext repo.

Since the behavior is shared across them, it's better to modify the
parent's function and remove the override from the children.

Just to be clear here: we completely ignore this information in our servers. We do not read it or save it anywhere.

@humitos humitos requested a review from rtfd/core Jun 22, 2018

@humitos humitos requested a review from agjohnson Jun 25, 2018

@agjohnson

I'm not sure which form might use a different id here. Maybe the .com forms?

Show outdated Hide outdated readthedocs/payments/static-src/payments/js/base.js Outdated

@humitos humitos requested a review from agjohnson Jun 25, 2018

humitos added some commits Jun 22, 2018

Clean CC sensible data on Gold subscriptions
`PaymentView.submit_form` function removes all CC sensible data.

This function is used for `GoldView` in this repo and also for
`DonateView` in -ext repo.

Since the behavior is shared across them, it's better to modify the
parent's function and remove the override from the children.
Standardize `card_digits` and `last_4_digits`
Use `last_4_card_digits` to avoid confusion and express exactly what
it contains.
@agjohnson

I think this looks fine. Once the related PRs are merged, we'll want to do a QA pass here as well.

@agjohnson agjohnson merged commit c32d612 into master Sep 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@agjohnson agjohnson deleted the humitos/stripe/blank-data branch Sep 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment