New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make `get_version` usable from a specified path #4376

Merged
merged 2 commits into from Jul 20, 2018

Conversation

Projects
None yet
3 participants
@humitos
Member

humitos commented Jul 16, 2018

Allow to use the get_version util by passing a path to a standard setup.cfg file instead of guess it as a relative path from current __file__.

@humitos humitos requested a review from rtfd/core Jul 16, 2018

@ericholscher

This comment has been minimized.

Show comment
Hide comment
@ericholscher

ericholscher Jul 18, 2018

Member

Seems like this is just moving where the guess setup.cfg logic is. I'm guessing this is meant to be extended somewhere else?

Member

ericholscher commented Jul 18, 2018

Seems like this is just moving where the guess setup.cfg logic is. I'm guessing this is meant to be extended somewhere else?

@humitos

This comment has been minimized.

Show comment
Hide comment
@humitos

humitos Jul 18, 2018

Member

@ericholscher yes, the idea is to share this get_version code with the corporate site: rtfd/readthedocs-corporate#369

In the corporate repo we pass a different setup.cfg path.

Member

humitos commented Jul 18, 2018

@ericholscher yes, the idea is to share this get_version code with the corporate site: rtfd/readthedocs-corporate#369

In the corporate repo we pass a different setup.cfg path.

@agjohnson agjohnson merged commit 9a5f019 into master Jul 20, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@agjohnson agjohnson deleted the humitos/module/version branch Jul 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment