Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add client ID to Google Analytics requests #4404
I think that I can't really review this in a good way, but after the deploy you said that the data we wanted to see in analytics wasn't being shown properly.
I guess this should be fine for now.
We may want to add a comment here explaining that what the docs says doesn't work as it should be and also maybe create a ticket to track this in the future and change it if we find that google fixes it?.
Just to clarify, when I removed the user ID, I did so based solely on the documentation which doesn't appear to be correct.
With adding this client ID, I tested an event with a client ID, saw it in the real-time report, and waited a day and saw it in processed reports.