New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client ID to Google Analytics requests #4404

Merged
merged 1 commit into from Jul 19, 2018

Conversation

Projects
None yet
3 participants
@davidfischer
Contributor

davidfischer commented Jul 19, 2018

This almost reverts #4347 but is slightly different as it sends a client ID instead of a user ID.

Google's documentation says that the client ID should be a UUID but in my testing and in Google's own JavaScript implementation this works without that being the case.

@davidfischer davidfischer requested a review from rtfd/core Jul 19, 2018

@humitos

I think that I can't really review this in a good way, but after the deploy you said that the data we wanted to see in analytics wasn't being shown properly.

I guess this should be fine for now.

We may want to add a comment here explaining that what the docs says doesn't work as it should be and also maybe create a ticket to track this in the future and change it if we find that google fixes it?.

@ericholscher

Yea, it feels a bit like shooting in the dark here. Did we test this locally against GA, and see that it worked? That seems like the best way to figure it out without having to deploy it.

@davidfischer

This comment has been minimized.

Show comment
Hide comment
@davidfischer

davidfischer Jul 19, 2018

Contributor

Did we test this locally against GA, and see that it worked?

Yes I did.

Contributor

davidfischer commented Jul 19, 2018

Did we test this locally against GA, and see that it worked?

Yes I did.

@davidfischer

This comment has been minimized.

Show comment
Hide comment
@davidfischer

davidfischer Jul 19, 2018

Contributor

Just to clarify, when I removed the user ID, I did so based solely on the documentation which doesn't appear to be correct.

With adding this client ID, I tested an event with a client ID, saw it in the real-time report, and waited a day and saw it in processed reports.

Contributor

davidfischer commented Jul 19, 2018

Just to clarify, when I removed the user ID, I did so based solely on the documentation which doesn't appear to be correct.

With adding this client ID, I tested an event with a client ID, saw it in the real-time report, and waited a day and saw it in processed reports.

@davidfischer davidfischer merged commit 67dfae9 into master Jul 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@davidfischer davidfischer deleted the davidfischer/ga-client-id branch Jul 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment