Join GitHub today
Match v1 config interface to new one #4456
I tried to reset the base, but i'm not sure it worked. Looks like a manual rebase is in order.
This sounds like you are going to implement all of these changes in one PR, which I would advise against. This is going to make another PR that takes a lot of effort to review. I'd rather we break this up into discrete chunks for each feature.
This was referenced
Aug 6, 2018
Good! I think the changes are good.
Although, I left some comments (and questions!) that I'd like to be considered and may imply other changes as well.
referenced this pull request
Aug 15, 2018
It seems that you
This PR in particular is too big and it's complicated to follow and review over and over.
Anyway, I think we are good here.