New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port https://github.com/rtfd/readthedocs-build/pull/38/ #4461

Merged
merged 2 commits into from Aug 27, 2018

Conversation

Projects
None yet
2 participants
@stsewd
Member

stsewd commented Aug 2, 2018

The problem was already fixed with the refactor, but anyway I want to add these tests.

Closes #2813

@stsewd stsewd requested a review from rtfd/core Aug 2, 2018

@stsewd stsewd referenced this pull request Aug 2, 2018

Closed

Allow explicit default with null value #38

2 of 2 tasks complete

@agjohnson agjohnson added this to the YAML File Completion milestone Aug 2, 2018

@agjohnson

LGTM!

@agjohnson agjohnson merged commit fefdea4 into rtfd:master Aug 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stsewd stsewd deleted the stsewd:port-rtd-build#38 branch Aug 28, 2018

source_file=str(tmpdir.join('readthedocs.yml')),
)
build.validate()
assert build.requirements_file is None

This comment has been minimized.

@stsewd

stsewd Aug 28, 2018

Member

Ups, forgot to rename this to the latest changes, I'll fix this in a couple of minutes

@stsewd

stsewd Aug 28, 2018

Member

Ups, forgot to rename this to the latest changes, I'll fix this in a couple of minutes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment