Join GitHub today
Allow enforcing HTTPS for custom domains #4483
This allows users to mark a domain as HTTPS and then all links to its documentation will be HTTPS links instead of HTTP links.
Personally I don't love these changes to the resolver but I believe the resolver needs a larger refactor for performance reasons anyway (#3712). If there's a better way to add this functionality without adding more SQL queries and degrading performance of a very performance sensitive bit of code, please let me know or feel free to add to this.
I think these changes are good.
I got a little lost on the review (as usual when taking a look at the resolver) but seems smooth. I left a refactor comment, but not 100% sure that I'm correct.
Besides the tests you changed, shouldn't we have a specific test that uses a
Domain(https=False) and check that it resolves to