New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache node_modules to speed up CI #4484

Merged
merged 1 commit into from Aug 15, 2018

Conversation

Projects
None yet
4 participants
@stsewd
Member

stsewd commented Aug 6, 2018

The CI process is a little slow, even sometimes it fails because of timeout downloading node packages. A downside of this change: we need to remember to clear the cache if there is a change in js dependencies (which is not so common).

@stsewd stsewd requested a review from rtfd/core Aug 6, 2018

@humitos

humitos approved these changes Aug 6, 2018

I'm 👍 with this change.

I prefer to speed up things in the day to day, and fail and clean when a node module has changed.

@ericholscher

ericholscher approved these changes Aug 7, 2018 edited

👍 on faster builds. I don't edit the node stuff much, but I wonder if there is a way to detect when it has changed and not cache it, or destroy the cache?

@stsewd

This comment has been minimized.

Show comment
Hide comment
@stsewd

stsewd Aug 8, 2018

Member

I wonder if there is a way to detect when it has changed and not cache it, or destroy the cache?

I think we only need to remind ourselves to clean the cache on travis, I'm not sure if travis clean the cache regularly, also, we don't have tests on the client side... So, no big problem I think

Member

stsewd commented Aug 8, 2018

I wonder if there is a way to detect when it has changed and not cache it, or destroy the cache?

I think we only need to remind ourselves to clean the cache on travis, I'm not sure if travis clean the cache regularly, also, we don't have tests on the client side... So, no big problem I think

@humitos

This comment has been minimized.

Show comment
Hide comment
@humitos

humitos Aug 8, 2018

Member

In fact, I think that we only need npm for eslint. So, I suppose that we will only note this in case we update our package.json for any eslint related package.

Member

humitos commented Aug 8, 2018

In fact, I think that we only need npm for eslint. So, I suppose that we will only note this in case we update our package.json for any eslint related package.

Show outdated Hide outdated .travis.yml Outdated
@safwanrahman

Requested change for caching npm cache directory

@humitos humitos merged commit ddf1ef8 into rtfd:master Aug 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stsewd stsewd deleted the stsewd:cache-node-modules branch Aug 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment