New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use HostHeaderSSLAdapter for SSL/HTTPS connections #4498

Merged
merged 2 commits into from Aug 9, 2018

Conversation

Projects
None yet
3 participants
@davidfischer
Contributor

davidfischer commented Aug 8, 2018

We made a mistake using HostHeaderSSLAdapter even when the connection wasn't HTTPS (in dev, that is). This causes problems connecting to the API.

Fixes #4494

@davidfischer davidfischer requested review from humitos and agjohnson Aug 8, 2018

@humitos

humitos approved these changes Aug 8, 2018

I'm 👍 with these changes.

I'm not sure if it's not good to expand a bit more the situation. Maybe not in the comment, but in the commit/PR description mentioning the assert_hostname kw and the difference that you found around HTTPSConnectionPool and HTTPConnectionPool.

Show outdated Hide outdated readthedocs/restapi/client.py Outdated
@davidfischer

This comment has been minimized.

Show comment
Hide comment
@davidfischer

davidfischer Aug 9, 2018

Contributor

I re-added the default adapter class.

Contributor

davidfischer commented Aug 9, 2018

I re-added the default adapter class.

@agjohnson

LGTM!

@agjohnson agjohnson merged commit 2d44811 into master Aug 9, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@agjohnson agjohnson deleted the davidfischer/hostheaderssladapter-fix branch Aug 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment