Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Support ads on pallets themes #4499
This will allow showing ads on "alabaster-like" themes which includes the pallets themes. It also no longer handles celery as a special case but as another "alabaster-like" theme.
To test on pallets themes you can:
A sidebar ad
A footer ad
Seems like this expands the scope of our ads to a lot more themes. This isn't inherently bad, but we should know that this is the outcome that we're wanting. I imagine it should be fine, but probably worth testing on some of the other common themes.
For example, I believe it will inject on the pypa theme as well: http://pip.readthedocs.io/en/stable/
Looks good. As a note, I'm +1 in general on using the sidebar heuristic at some point to enable ads on more themes. I think it's going to be an easy way to get most of the common themes, and a lot of the long tail. It's just something we need to do when we have time to message and support it.
Aug 10, 2018
1 check passed
I liked the latest changes. Although, it doesn't change the heuristic to decide if it's an ALABASTER-like theme or not. We are still using the same check (