New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for period as a prefix and yaml extension for config file #4512

Merged
merged 5 commits into from Aug 27, 2018

Conversation

Projects
None yet
4 participants
@StefanoChiodino
Contributor

StefanoChiodino commented Aug 13, 2018

Fixes #4102 bringing it over from the build repo.

Ref. rtfd/readthedocs-build#48

@humitos

Changes look great! Thanks.

@stsewd

Thanks, I just left some comments about the code style.

Show outdated Hide outdated readthedocs/config/config.py Outdated
Show outdated Hide outdated readthedocs/config/tests/test_config.py Outdated
Show outdated Hide outdated readthedocs/config/tests/test_config.py Outdated
@stsewd

This comment has been minimized.

Show comment
Hide comment
@stsewd

stsewd Aug 13, 2018

Member

Also, there is a test that needs to be changed https://travis-ci.org/rtfd/readthedocs.org/jobs/415587982#L970

Member

stsewd commented Aug 13, 2018

Also, there is a test that needs to be changed https://travis-ci.org/rtfd/readthedocs.org/jobs/415587982#L970

@StefanoChiodino

This comment has been minimized.

Show comment
Hide comment
@StefanoChiodino

StefanoChiodino Aug 24, 2018

Contributor

Sorry this took me a while! Hopefully this should pass now :)

Contributor

StefanoChiodino commented Aug 24, 2018

Sorry this took me a while! Hopefully this should pass now :)

@stsewd

stsewd approved these changes Aug 24, 2018

Thanks!

Show outdated Hide outdated readthedocs/config/tests/test_config.py Outdated
@agjohnson

This comment has been minimized.

Show comment
Hide comment
@agjohnson

agjohnson Aug 27, 2018

Contributor

Looks great! Thanks a ton for porting the PR over!

Contributor

agjohnson commented Aug 27, 2018

Looks great! Thanks a ton for porting the PR over!

@agjohnson agjohnson merged commit c670e18 into rtfd:master Aug 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment