New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the STATIC_URL for static files to avoid redirection #4522

Merged
merged 3 commits into from Aug 21, 2018

Conversation

Projects
None yet
3 participants
@davidfischer
Contributor

davidfischer commented Aug 14, 2018

This PR cleans up a few areas that were using MEDIA_URL but really should be using STATIC_URL after #4489. The old URL will work but will result in a redirect which slows things down and results in an extra hit.

@davidfischer davidfischer requested a review from rtfd/core Aug 14, 2018

@ericholscher

Looks good. Just want to make sure we aren't breaking backwards compat, at least for now.

Keep MEDIA_URL just in case
- This may be removed when the new theme context is implemented
https://docs.readthedocs.io/en/latest/design/theme-context.html
@davidfischer

This comment has been minimized.

Show comment
Hide comment
@davidfischer

davidfischer Aug 15, 2018

Contributor

I re-added the MEDIA_URL back.

Contributor

davidfischer commented Aug 15, 2018

I re-added the MEDIA_URL back.

@davidfischer davidfischer merged commit 9ee283c into master Aug 21, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@davidfischer davidfischer deleted the davidfischer/media-to-static-cleanup branch Aug 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment