New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance improvement: cache version listing on the homepage #4526

Merged
merged 7 commits into from Aug 15, 2018

Conversation

Projects
None yet
4 participants
@ericholscher
Member

ericholscher commented Aug 15, 2018

This is similar to #4524,
where resolving a ton of URL's for versions is time consuming.
This caches the features projects list on the homepage.

ericholscher added some commits Aug 15, 2018

Performance improvement: stop listing all versions on the homepage
This is similar to #4524,
where resolving a ton of URL's for versions is time consuming.
This limits that by only listing the stable version,
 if it exists,
for featured projects on our homepage

@ericholscher ericholscher changed the title from Performance improvement: stop listing all versions on the homepage to Performance improvement: cache version listing on the homepage Aug 15, 2018

@ericholscher ericholscher requested review from davidfischer and rtfd/core and removed request for davidfischer Aug 15, 2018

@ericholscher

This comment has been minimized.

Show comment
Hide comment
@ericholscher

ericholscher Aug 15, 2018

Member

Outcome in testing on one of our web servers:

screenshot 2018-08-15 21 21 56

That is 1500ms to 100ms.

Member

ericholscher commented Aug 15, 2018

Outcome in testing on one of our web servers:

screenshot 2018-08-15 21 21 56

That is 1500ms to 100ms.

@agjohnson

I'm surprised we haven't done this yet. 👍

Show outdated Hide outdated readthedocs/templates/homepage.html Outdated
@davidfischer

Looks good to me! We could use something similar to get the number of projects as well but if this takes care of it, no worries.

@ericholscher ericholscher merged commit 83da8d3 into master Aug 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stsewd stsewd deleted the hide-project-versions branch Aug 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment