New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hiredis #4542

Merged
merged 1 commit into from Aug 27, 2018

Conversation

Projects
None yet
3 participants
@ericholscher
Member

ericholscher commented Aug 20, 2018

This might be the cause of our random celery disconnects.

Refs celery/celery#2606 (comment)

Remove hiredis
This might be the cause of our random celery disconnects.

Refs celery/celery#2606 (comment)

@ericholscher ericholscher requested a review from rtfd/core Aug 20, 2018

@ericholscher

This comment has been minimized.

Show comment
Hide comment
@ericholscher

ericholscher Aug 20, 2018

Member

I've hotfixed this to see if it solves our disconnect issues.

Member

ericholscher commented Aug 20, 2018

I've hotfixed this to see if it solves our disconnect issues.

@ericholscher

This comment has been minimized.

Show comment
Hide comment
@ericholscher
Member

ericholscher commented Aug 23, 2018

@rtfd/core ping :)

@humitos

Sounds good to me.

We don't have a way to know if this will work, but we didn't see a disconnection since then. Worth to test :)

Also, besides removing it from there, I suppose we should do a pip uninstall because I think that's not done automatically. Is that the current hotfixed?

@ericholscher

This comment has been minimized.

Show comment
Hide comment
@ericholscher

ericholscher Aug 23, 2018

Member

Yep, I hotfixed it that way, but it got reinstalled whenever we installed the prod dependencies.

Member

ericholscher commented Aug 23, 2018

Yep, I hotfixed it that way, but it got reinstalled whenever we installed the prod dependencies.

@humitos humitos self-assigned this Aug 27, 2018

@humitos

This comment has been minimized.

Show comment
Hide comment
@humitos

humitos Aug 27, 2018

Member

I'm merging this PR and running to hotfix this:

celery -A readthedocs control shutdown
pip uninstall hiredis

Then,

supervisorctl restart build

and,

supervisorctl restart web
Member

humitos commented Aug 27, 2018

I'm merging this PR and running to hotfix this:

celery -A readthedocs control shutdown
pip uninstall hiredis

Then,

supervisorctl restart build

and,

supervisorctl restart web

@humitos humitos merged commit ed0a91c into master Aug 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@humitos humitos deleted the remove-hiredis branch Aug 27, 2018

@humitos

This comment has been minimized.

Show comment
Hide comment
@humitos

humitos Aug 27, 2018

Member

I also restarted these on webs

supervisorctl restart celery:celery-beat celery:celery-web celery:celery-web02 web
Member

humitos commented Aug 27, 2018

I also restarted these on webs

supervisorctl restart celery:celery-beat celery:celery-web celery:celery-web02 web
@humitos

This comment has been minimized.

Show comment
Hide comment
@humitos

humitos Sep 11, 2018

Member

Since we applied this we have not experience more issues with workers being disconnected! I think this is a win 🎉

Member

humitos commented Sep 11, 2018

Since we applied this we have not experience more issues with workers being disconnected! I think this is a win 🎉

@ericholscher

This comment has been minimized.

Show comment
Hide comment
@ericholscher
Member

ericholscher commented Sep 12, 2018

💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment