New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build JSON artifacts in HTML builder #4554

Merged
merged 4 commits into from Aug 22, 2018

Conversation

Projects
None yet
3 participants
@humitos
Member

humitos commented Aug 22, 2018

This removes the Feature BUILD_JSON_ARTIFACTS_WITH_HTML and makes this the default for all the projects.

It also removes the SearchBuilder since it's not used anymore.

Depends on rtfd/readthedocs-sphinx-ext#50
Related #4229 and rtfd/readthedocs-corporate#378

json_path = os.path.abspath(
os.path.join(self.old_artifact_path, '..', 'json')
# Copy JSON artifacts to its own directory
# to keep compatibility with the older builder.

This comment has been minimized.

@humitos

humitos Aug 22, 2018

Member

This comment confuses me a little.

What is what we need to keep compatibility to?

@humitos

humitos Aug 22, 2018

Member

This comment confuses me a little.

What is what we need to keep compatibility to?

This comment has been minimized.

@ericholscher

ericholscher Aug 22, 2018

Member

With the code that copies the build artifacts onto the web servers.

@ericholscher

ericholscher Aug 22, 2018

Member

With the code that copies the build artifacts onto the web servers.

@ericholscher

👍 💯 Glad to get this rolled out everywhere.

json_path = os.path.abspath(
os.path.join(self.old_artifact_path, '..', 'json')
# Copy JSON artifacts to its own directory
# to keep compatibility with the older builder.

This comment has been minimized.

@ericholscher

ericholscher Aug 22, 2018

Member

With the code that copies the build artifacts onto the web servers.

@ericholscher

ericholscher Aug 22, 2018

Member

With the code that copies the build artifacts onto the web servers.

Show outdated Hide outdated readthedocs/doc_builder/templates/doc_builder/conf.py.tmpl Outdated
Show outdated Hide outdated readthedocs/doc_builder/templates/doc_builder/conf.py.tmpl Outdated
@humitos

This comment has been minimized.

Show comment
Hide comment
@humitos
Member

humitos commented Aug 22, 2018

All tests passed: https://travis-ci.org/rtfd/readthedocs.org/builds/419204927?utm_source=github_status&utm_medium=notification

I don't know why this is not reporting properly to GH.

@stsewd

This comment has been minimized.

Show comment
Hide comment
@stsewd

stsewd Aug 22, 2018

Member

I restarted a job to refresh the state, now it's all green!

Member

stsewd commented Aug 22, 2018

I restarted a job to refresh the state, now it's all green!

humitos added some commits Aug 22, 2018

Build JSON artifacts in HTML builder
This removes the Feature BUILD_JSON_ARTIFACTS_WITH_HTML and makes this
the default for all the projects.

It also removes the SearchBuilder since it's not used anymore.
@humitos

This comment has been minimized.

Show comment
Hide comment
@humitos

humitos Aug 22, 2018

Member

Rebase and ready to merge. Waiting for tests to pass.

Member

humitos commented Aug 22, 2018

Rebase and ready to merge. Waiting for tests to pass.

@humitos humitos merged commit cab4363 into master Aug 22, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@humitos humitos deleted the humitos/search/remove-builder-json-feature branch Aug 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment