New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a flag to disable docsearch #4570

Merged
merged 4 commits into from Aug 25, 2018

Conversation

Projects
None yet
2 participants
@davidfischer
Contributor

davidfischer commented Aug 24, 2018

Add a JS flag under READTHEDOCS_DATA for disabling docsearch.

Longer term, there will be a server side staff-only feature flag which sets the same variable. Ideally this feature can completely go away once the search improvements are deployed.

Related to #4452.

davidfischer added some commits Aug 24, 2018

@davidfischer davidfischer requested a review from rtfd/core Aug 24, 2018

@agjohnson

LGTM. We could recompile assets here or against rel maybe.

@davidfischer

This comment has been minimized.

Show comment
Hide comment
@davidfischer

davidfischer Aug 25, 2018

Contributor

I checked in the compiled version. I'll do a squash and merge.

Contributor

davidfischer commented Aug 25, 2018

I checked in the compiled version. I'll do a squash and merge.

@davidfischer davidfischer merged commit dbad255 into master Aug 25, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@davidfischer davidfischer deleted the davidfischer/disable-search-js-flag branch Aug 25, 2018

davidfischer added a commit that referenced this pull request Aug 25, 2018

Add a flag to disable docsearch (#4570)
* Add a flag to disable docsearch

* Disable Docsearch with a feature on READTHEDOCS_DATA

* Make the comment clearer

* Checkin compiled built assets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment