New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests failing on master #4575

Merged
merged 1 commit into from Aug 28, 2018

Conversation

Projects
None yet
3 participants
@stsewd
Member

stsewd commented Aug 28, 2018

Ref to #4461 (comment)

So, this was caused because the PR was outdated, makes me think if we could do better to prevent this. What about requiring the PRs to be updated before merging to master? Now GitHub supports a button to update the PR from the web, so the process isn't slow, but we will need to wait to the tests to pass again with the new merge, for simple PRs this can be a little overkill, but in general, I think this is a sane check

@agjohnson

This comment has been minimized.

Show comment
Hide comment
@agjohnson

agjohnson Aug 28, 2018

Contributor

Changes look good!

What part of the PR wasn't updated? Do you mean you had local commits ready and didn't push up to your branch on GitHub yet?

Contributor

agjohnson commented Aug 28, 2018

Changes look good!

What part of the PR wasn't updated? Do you mean you had local commits ready and didn't push up to your branch on GitHub yet?

@stsewd

This comment has been minimized.

Show comment
Hide comment
@stsewd

stsewd Aug 28, 2018

Member

The PR was done before #4456, so it was using the old interface. Then the new interface was merged, and the tests were keeping the old interface.

Member

stsewd commented Aug 28, 2018

The PR was done before #4456, so it was using the old interface. Then the new interface was merged, and the tests were keeping the old interface.

@humitos humitos merged commit dde104d into rtfd:master Aug 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stsewd stsewd deleted the stsewd:update-tests branch Aug 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment