New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add start and termination to YAML file regex #4584

Merged
merged 3 commits into from Aug 29, 2018

Conversation

Projects
None yet
3 participants
@humitos
Member

humitos commented Aug 29, 2018

Otherwise it found files like:

.hg/store/data/readthedocs.yml.i

Closes #4583

@humitos

This comment has been minimized.

Show comment
Hide comment
@humitos

humitos Aug 29, 2018

Member

It would be good to have a test for this :)

Member

humitos commented Aug 29, 2018

It would be good to have a test for this :)

humitos added some commits Aug 29, 2018

Add start and termination to YAML file regex
Otherwise it found files like:

  .hg/store/data/readthedocs.yml.i
@agjohnson

This comment has been minimized.

Show comment
Hide comment
@agjohnson

agjohnson Aug 29, 2018

Contributor

Added #4586 in case this is closed before

Contributor

agjohnson commented Aug 29, 2018

Added #4586 in case this is closed before

@stsewd

This comment has been minimized.

Show comment
Hide comment
@stsewd

stsewd Aug 29, 2018

Member

I'm pushing some tests right now

Member

stsewd commented Aug 29, 2018

I'm pushing some tests right now

@stsewd stsewd referenced this pull request Aug 29, 2018

Merged

Tests for yaml file regex #4587

@stsewd

This comment has been minimized.

Show comment
Hide comment
@stsewd

stsewd Aug 29, 2018

Member

Tests in #4587

Member

stsewd commented Aug 29, 2018

Tests in #4587

@agjohnson agjohnson removed the PR: hotfix label Aug 29, 2018

@agjohnson

🐛 👢

@agjohnson agjohnson merged commit dcb4270 into master Aug 29, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@agjohnson agjohnson deleted the humitos/yaml/regex branch Aug 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment