New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect user language when caching homepage #4585

Merged
merged 2 commits into from Aug 29, 2018

Conversation

Projects
None yet
2 participants
@agjohnson
Contributor

agjohnson commented Aug 29, 2018

Previously it was using the first language that hit the page to cache.

Fixes #4582

Respect user language when caching homepage
Previously it was using the first language that hit the page to cache.

@agjohnson agjohnson requested a review from rtfd/core Aug 29, 2018

@agjohnson agjohnson added this to the 2.7 milestone Aug 29, 2018

@agjohnson

This comment has been minimized.

Show comment
Hide comment
@agjohnson

agjohnson Aug 29, 2018

Contributor

Failure unrelated.

Contributor

agjohnson commented Aug 29, 2018

Failure unrelated.

@agjohnson agjohnson added PR: hotfix and removed PR: hotfix labels Aug 29, 2018

@agjohnson

This comment has been minimized.

Show comment
Hide comment
@agjohnson

agjohnson Aug 29, 2018

Contributor

Just going to merge this. @rtfd/core be wary of this when caching new things.

Contributor

agjohnson commented Aug 29, 2018

Just going to merge this. @rtfd/core be wary of this when caching new things.

@agjohnson agjohnson merged commit fd4cc67 into master Aug 29, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@agjohnson agjohnson deleted the agj/cache-homepage-with-language branch Aug 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment