New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing the indexing #4615

Merged
merged 5 commits into from Sep 7, 2018

Conversation

Projects
None yet
2 participants
@safwanrahman
Member

safwanrahman commented Sep 6, 2018

@ericholscher It should fix the search indexing!

@ericholscher

ericholscher approved these changes Sep 6, 2018 edited

Looks good after lint fixes. 👍

@ericholscher

This comment has been minimized.

Show comment
Hide comment
@ericholscher

ericholscher Sep 6, 2018

Member

I think we probably need to support both a list of object ID's for normal running, and also a start/end for reindexing perhaps

Member

ericholscher commented Sep 6, 2018

I think we probably need to support both a list of object ID's for normal running, and also a start/end for reindexing perhaps

@safwanrahman

This comment has been minimized.

Show comment
Hide comment
@safwanrahman

safwanrahman Sep 6, 2018

Member

@ericholscher Oops! I missed that!
updated to support both chunk and objects id.

Member

safwanrahman commented Sep 6, 2018

@ericholscher Oops! I missed that!
updated to support both chunk and objects id.

@ericholscher ericholscher merged commit 3ca137c into rtfd:search_upgrade Sep 7, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@ericholscher

This comment has been minimized.

Show comment
Hide comment
@ericholscher
Member

ericholscher commented Sep 7, 2018

👍

safwanrahman added a commit to safwanrahman/readthedocs.org that referenced this pull request Sep 15, 2018

safwanrahman added a commit to safwanrahman/readthedocs.org that referenced this pull request Sep 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment