New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change mentions of "CNAME" -> custom domain #4627

Merged
merged 2 commits into from Sep 13, 2018

Conversation

Projects
None yet
3 participants
@agjohnson
Contributor

agjohnson commented Sep 10, 2018

CNAME refers to a DNS construct, not an RTD construct. Referring to these as
"custom domain" instead makes this information easier to understand/find.

Also includes some random cleanup of copy around the CNAME -> custom domain
changes.

Change mentions of "CNAME" -> custom domain
Also some related cleanup of copy around the CNAME -> custom domain
changes.

@agjohnson agjohnson requested a review from rtfd/core Sep 10, 2018

@agjohnson agjohnson added this to the 2.7 milestone Sep 10, 2018

@davidfischer

I had one small fix but this looks good.

Show outdated Hide outdated docs/features.rst
@RichardLitt

Small change, but LGTM.

@agjohnson agjohnson merged commit 4f1a5dc into master Sep 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@agjohnson agjohnson deleted the agj/stop-calling-it-cname branch Sep 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment