New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ads more obvious that they are ads #4628

Merged
merged 2 commits into from Sep 12, 2018

Conversation

Projects
None yet
2 participants
@davidfischer
Contributor

davidfischer commented Sep 10, 2018

  • A few visual tweaks
    • Adds a box with a background color around the ad so as to separate it from other content.
    • Links are always underlined.
    • Text in footer ads is a bit smaller
    • Slightly increases the padding around the ad container
    • The "sponsored" and "ads served ethically" text is blended a bit with the background so it emphasizes the actual ad. It is also always centered even on footer ads (previously it was right aligned).
  • Adds a dark theme for ads that looks good on the RTD theme but could be used elsewhere if needed.

Note: this doesn't change any of the CSS classes for of our ads. Ad blockers will continue to work as normal. This means we shouldn't need to contact our partners at Eyeo/AdblockPlus with respect to "acceptable ads".

Screenshots

Sidebar on RTD

screen shot 2018-09-10 at 12 25 38 pm

Footer on RTD

screen shot 2018-09-10 at 12 25 23 pm

Sidebar on Alabaster

screen shot 2018-09-10 at 12 24 49 pm

Footer on Alabaster

screen shot 2018-09-10 at 12 24 36 pm

@davidfischer davidfischer requested a review from rtfd/core Sep 10, 2018

@ericholscher

Looks great. 💯

@davidfischer davidfischer merged commit d43783f into master Sep 12, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stsewd stsewd deleted the davidfischer/ad-reformat branch Sep 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment