New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor PublicTask into a decorator task #4656

Merged
merged 2 commits into from Oct 2, 2018

Conversation

Projects
None yet
2 participants
@stsewd
Member

stsewd commented Sep 21, 2018

Still wip, I need to update some docstrings, but I already tested it, and it works :)

Fix #3974 and ref to #3973

user = User.objects.get(pk=user_id)
for service_cls in registry:
for service in service_cls.for_user(user):
service.sync()

This comment has been minimized.

@stsewd

stsewd Sep 21, 2018

Member

The api for defining a public task is cleaner now :D

@stsewd

stsewd Sep 21, 2018

Member

The api for defining a public task is cleaner now :D

This comment has been minimized.

@agjohnson

agjohnson Oct 2, 2018

Contributor

Much nicer!

@agjohnson

agjohnson Oct 2, 2018

Contributor

Much nicer!

Show outdated Hide outdated readthedocs/oauth/tasks.py Outdated
@stsewd

This comment has been minimized.

Show comment
Hide comment
@stsewd

stsewd Sep 21, 2018

Member

I believe this is ready, I also tested it locally, it works as expected.

Member

stsewd commented Sep 21, 2018

I believe this is ready, I also tested it locally, it works as expected.

@agjohnson

Looks great! We'll want to make sure this has some QA before release, but I don't think we use public task anywhere else at the moment.

user = User.objects.get(pk=user_id)
for service_cls in registry:
for service in service_cls.for_user(user):
service.sync()

This comment has been minimized.

@agjohnson

agjohnson Oct 2, 2018

Contributor

Much nicer!

@agjohnson

agjohnson Oct 2, 2018

Contributor

Much nicer!

@agjohnson agjohnson merged commit a8bd00a into rtfd:master Oct 2, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stsewd stsewd deleted the stsewd:refactor-public-task branch Oct 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment