New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up logging #4665

Merged
merged 2 commits into from Oct 2, 2018

Conversation

Projects
None yet
3 participants
@stsewd
Member

stsewd commented Sep 25, 2018

Following up to #3677

@@ -517,16 +514,6 @@ def handle_exception(self, exc_type, exc_value, _):
def record_command(self, command):
command.save()
def _log_warning(self, msg):
# :'(

This comment has been minimized.

@stsewd

stsewd Sep 25, 2018

Member

Goodbye sad face :(

@stsewd

stsewd Sep 25, 2018

Member

Goodbye sad face :(

This comment has been minimized.

@RichardLitt

RichardLitt Sep 26, 2018

Member

He'll still be in our git history. :')

@RichardLitt

RichardLitt Sep 26, 2018

Member

He'll still be in our git history. :')

@agjohnson

LGTM! We do this in a couple places, but nice to at least refactor this out for now.

@agjohnson

This comment has been minimized.

Show comment
Hide comment
@agjohnson

agjohnson Oct 2, 2018

Contributor

Waiting on tests after merge conflict updates, then probably safe to merge this.

Contributor

agjohnson commented Oct 2, 2018

Waiting on tests after merge conflict updates, then probably safe to merge this.

@agjohnson agjohnson merged commit 61165ba into rtfd:master Oct 2, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stsewd stsewd deleted the stsewd:cleanup-logging branch Oct 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment