New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "auto refresh false" #4701

Merged
merged 1 commit into from Oct 2, 2018

Conversation

Projects
None yet
2 participants
@ericholscher
Member

ericholscher commented Oct 2, 2018

This reverts commit 51c109b.

@ericholscher

This comment has been minimized.

Show comment
Hide comment
@ericholscher

ericholscher Oct 2, 2018

Member

Doing this to fix tests, and it didn't seem to fix our issues with ES.

Member

ericholscher commented Oct 2, 2018

Doing this to fix tests, and it didn't seem to fix our issues with ES.

@ericholscher ericholscher merged commit abc4b87 into master Oct 2, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ericholscher

This comment has been minimized.

Show comment
Hide comment
@ericholscher

ericholscher Oct 2, 2018

Member

@rtfd/core @safwanrahman Just a heads up I reverted this so tests aren't totally broken ^^

Member

ericholscher commented Oct 2, 2018

@rtfd/core @safwanrahman Just a heads up I reverted this so tests aren't totally broken ^^

@safwanrahman

This comment has been minimized.

Show comment
Hide comment
@safwanrahman

safwanrahman Oct 2, 2018

Member

@ericholscher This fix is needed for search optimization. we can skip the search test till I fix the tests!

Member

safwanrahman commented Oct 2, 2018

@ericholscher This fix is needed for search optimization. we can skip the search test till I fix the tests!

@stsewd stsewd deleted the fix-search-tests branch Oct 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment