Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement get objects or log #4900

Merged
merged 12 commits into from Jan 23, 2019
Merged

Implement get objects or log #4900

merged 12 commits into from Jan 23, 2019

Conversation

dojutsu-user
Copy link
Member

Fixes #4803

@codecov
Copy link

codecov bot commented Nov 13, 2018 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (master@3304193). Click here to learn what that means.
The diff coverage is 86.66%.

@@            Coverage Diff            @@
##             master    #4900   +/-   ##
=========================================
  Coverage          ?   76.98%           
=========================================
  Files             ?      158           
  Lines             ?    10057           
  Branches          ?     1264           
=========================================
  Hits              ?     7742           
  Misses            ?     1979           
  Partials          ?      336
Impacted Files Coverage Δ
readthedocs/builds/managers.py 100% <100%> (ø)
readthedocs/projects/tasks.py 71.76% <71.42%> (ø)

@dojutsu-user
Copy link
Member Author

@humitos
Please review.

@agjohnson
Copy link
Contributor

@dojutsu-user Just a heads up, requesting review directly from someone on core isn't necessary, someone will review the work when time allows.

@agjohnson agjohnson added this to the Refactoring milestone Nov 13, 2018
@dojutsu-user
Copy link
Member Author

@agjohnson
I will take care of it in the future.

@stsewd stsewd added the Needed: tests Tests are required label Nov 21, 2018
@dojutsu-user
Copy link
Member Author

I have added the tests, it is ready for review.

@stsewd stsewd removed the Needed: tests Tests are required label Jan 22, 2019
humitos
humitos requested changes Jan 22, 2019
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good. I noted some minimal changes to make.

readthedocs/builds/managers.py Outdated Show resolved Hide resolved
readthedocs/builds/managers.py Outdated Show resolved Hide resolved
readthedocs/builds/managers.py Show resolved Hide resolved
@ericholscher ericholscher merged commit 4c8c4f6 into readthedocs:master Jan 23, 2019
@ericholscher
Copy link
Member

👍

@dojutsu-user dojutsu-user deleted the implement-get-objects-or-log branch January 23, 2019 16:26
@dojutsu-user dojutsu-user mentioned this pull request Jan 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos humitos requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Refactoring
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dojutsu-user @agjohnson @ericholscher @humitos @stsewd