Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change some info logging to debug to clean up build output #5233

Merged
merged 2 commits into from Feb 11, 2019

Conversation

ericholscher
Copy link
Member

This should make it easier to follow along with builds. If you need the additional logging, you can always do tail -F logs/debug.log.

This should make it easier to follow along with builds. If you need the additional logging, you can always do `tail -F logs/debug.log`.
@ericholscher ericholscher requested a review from a team February 5, 2019 15:16
else:
resp = api_v2.command.post(data)
log.info('Post response via JSON encoded data: %s', resp)
log.debug('Post response via JSON encoded data: %s', resp)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the most important, as they are currently spamming our build logs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was added because we were experimenting some issues while posting big outputs. That is working fine now and I think the logs are not more necessary. 👍 on .debug it.

Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good!

If you need the additional logging, you can always do tail -F logs/debug.log.

I think this is possible on local development, but it does not work in production, right? I'm assuming that the log level we have configured is INFO.

else:
resp = api_v2.command.post(data)
log.info('Post response via JSON encoded data: %s', resp)
log.debug('Post response via JSON encoded data: %s', resp)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was added because we were experimenting some issues while posting big outputs. That is working fine now and I think the logs are not more necessary. 👍 on .debug it.

@ericholscher
Copy link
Member Author

I think this is possible on local development, but it does not work in production, right? I'm assuming that the log level we have configured is INFO.

Yep. We could write a debug log in prod perhaps, and only keep it for 1 day, since it's quite spammy. It's often times useful to have debug logging in prod even tho.

@ericholscher ericholscher merged commit 20a9d28 into master Feb 11, 2019
@delete-merged-branch delete-merged-branch bot deleted the reduce-build-logging branch February 11, 2019 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants