/sphinx_rtd_theme

Modernizr is not used #245

Closed
mitya57 opened this Issue Sep 11, 2015 · 1 comment

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mitya57 @Blendify
@mitya57
Contributor

mitya57 commented Sep 11, 2015

Hi, I wonder why does RTD theme use modernizr.min.js file.

I tried grepping JS files for usage of Modernizr object, and SASS files for typical Modernizr .foo and .no-foo classes, but could find neither of them.

Is Modernizr really used anywhere? If the answer is no, then I'll be happy to provide a pull request to get rid of it.

mitya57 added a commit to mitya57/sphinx_rtd_theme that referenced this issue Sep 16, 2015

@mitya57
Remove modernizr.js, we are not using it 
Fixes #245.
2aa4ce3

mitya57 added a commit to mitya57/sphinx_rtd_theme that referenced this issue Sep 16, 2015

@mitya57
Remove modernizr.js, we are not using it 
Also remove no longer needed classes from root `html` element.

Fixes #245.
d458567

@mitya57 mitya57 referenced this issue Sep 16, 2015

Closed

Remove modernizr.js, we are not using it #248

@Blendify
Contributor

Blendify commented Mar 9, 2017

Closing, see discussion in PR.

@Blendify Blendify closed this Mar 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment