Join GitHub today
Resolve scrollbar visibility on navbar on long content #215
This fixes #200, where a scrollbar was sometimes visible on the navbar. This
This fixes this issue by:
This was tested to be working in both cases on a variety of platforms: Linux FF,
The JS to dynamically modify the HTML if it's out of sync with the new CSS seems like a pretty... exciting approach. ;-)
Presumably this is only an issue on RTD, right? For people building with the theme locally, the HTML and the CSS should always be from the same version of the theme, so tricks like this shouldn't be necessary. If that is the case, it seems like the JS to dynamically tweak the HTML should be in RTD itself, not in the theme code.
RTD could also do a couple of things to reduce the need for things like this:
This would be an issue for RTD, but also possibly for forks of this theme that aren't pinned to 0.1.7.
I lean towards keeping it here, as RTD is the main use case for this theme. It will definitely have to live on RTD either way however. Our opinion is we shouldn't force a rebuild on documentation for this. Versioned assets are on our roadmap, but would require some significant changes to be able to handle all the cases that we need to handle on RTD.
If we change the HTML and don't provide graceful degradation here, this should be a backwards incompatible version.