New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dependency in dev setup: sphinxcontrib-httpdomain #431

Merged
merged 2 commits into from Jun 17, 2017

Conversation

Projects
None yet
3 participants
@benjaoming
Contributor

benjaoming commented Jun 15, 2017

Fixes #430

@Blendify

This comment has been minimized.

Contributor

Blendify commented Jun 15, 2017

Maybe we want to create a requirements.txt file instead?

@benjaoming

This comment has been minimized.

Contributor

benjaoming commented Jun 15, 2017

This is a development requirement, so in that case it would seem confusing IMO.

@Blendify

This comment has been minimized.

Contributor

Blendify commented Jun 17, 2017

I think this should be fine, it is not a huge project with a dozen requirements.

@Blendify Blendify self-requested a review Jun 17, 2017

@Blendify Blendify merged commit 1dc21db into rtfd:master Jun 17, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

travismiller added a commit to broco1974/couscous-template-readthedocs that referenced this pull request Dec 4, 2017

Merge commit '6c2302472fb2c61eec9b4be3a2515117fffbfac3' into rtfd
* commit '6c2302472fb2c61eec9b4be3a2515117fffbfac3': (253 commits)
  Add pygments_style to theme.conf
  Document new theme option
  Add option to layout.html
  Update theme.conf
  Apply clearfix on breadcrumbs
  Follow-up grunt for rtfd#472 (rtfd#476)
  Only change current if a matching link is found (rtfd#472)
  Add a couple of badge icons to readme (rtfd#471)
  Add Sphinx Framework for PyPi (rtfd#470)
  Fix error in setup entry points (rtfd#466)
  Added `.admonition` to the CSS (rtfd#462)
  Use explicit UTF8 encoding (rtfd#452)
  Add missing pygments css link
  Convert underscores to dashes.
  Reflect language in lang attribute.
  Replace master with v0.2.5 in README.rst
  Add missing dependency in dev setup: sphinxcontrib-httpdomain (rtfd#431)
  Finalized rtfd#418 (rtfd#433)
  Added a link to the Sphinx documentation about setuptools entry points
  Added setuptools entry point for Sphinx
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment