New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #166: Add missing pygments css link #448

Merged
merged 5 commits into from Dec 3, 2017

Conversation

Projects
None yet
4 participants
@Blendify
Contributor

Blendify commented Jul 30, 2017

Fix #166: Add missing pygments css link

@Blendify Blendify requested review from ericholscher and agjohnson Jul 30, 2017

@Blendify Blendify changed the title from Add missing pygments css link to Fix #166: Add missing pygments css link Jul 30, 2017

@Blendify Blendify added this to the v0.2.6 milestone Jul 30, 2017

@Blendify

This comment has been minimized.

Show comment
Hide comment
@Blendify

Blendify Sep 28, 2017

Contributor

This will also be fixed by #467

Contributor

Blendify commented Sep 28, 2017

This will also be fixed by #467

@Blendify Blendify closed this Sep 28, 2017

@Blendify Blendify reopened this Nov 25, 2017

Blendify added some commits Nov 25, 2017

@Blendify Blendify modified the milestones: v0.2.6, v0.2.5 Dec 3, 2017

@ericholscher ericholscher merged commit 6c23024 into master Dec 3, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@Blendify

This comment has been minimized.

Show comment
Hide comment
@Blendify

Blendify Dec 3, 2017

Contributor

Did you test the changes? Because I think that we are pulling some sass from wyrm that might be overriding this

Contributor

Blendify commented Dec 3, 2017

Did you test the changes? Because I think that we are pulling some sass from wyrm that might be overriding this

@ericholscher

This comment has been minimized.

Show comment
Hide comment
@ericholscher

ericholscher Dec 3, 2017

Member

I figured you had tested it, no? It is in the Sphinx docs, so figured we should do it. Seems like putting it after the theme CSS would make sure it's supported.

Member

ericholscher commented Dec 3, 2017

I figured you had tested it, no? It is in the Sphinx docs, so figured we should do it. Seems like putting it after the theme CSS would make sure it's supported.

@Blendify

This comment has been minimized.

Show comment
Hide comment
@Blendify

Blendify Dec 3, 2017

Contributor
Contributor

Blendify commented Dec 3, 2017

@Blendify

This comment has been minimized.

Show comment
Hide comment
@Blendify

Blendify Dec 3, 2017

Contributor
Contributor

Blendify commented Dec 3, 2017

@ax3l

This comment has been minimized.

Show comment
Hide comment
@ax3l

ax3l May 4, 2018

As reported in rtfd/readthedocs.org#4050 (comment), one should set the background for .highlight classes now in the rtd theme. The default is now green (on the white rtd background; pygments_style = 'sphinx').
bg_green

or one adds a pygments style for sphinx-rtd :)

edit: oh wait, pygments_style = 'default' should be fine.

ax3l commented May 4, 2018

As reported in rtfd/readthedocs.org#4050 (comment), one should set the background for .highlight classes now in the rtd theme. The default is now green (on the white rtd background; pygments_style = 'sphinx').
bg_green

or one adds a pygments style for sphinx-rtd :)

edit: oh wait, pygments_style = 'default' should be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment