New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only change current if a matching link is found #472

Merged
merged 1 commit into from Oct 13, 2017

Conversation

Projects
None yet
4 participants
@petermd
Contributor

petermd commented Oct 4, 2017

Fix for #397 to only reset current style and re-apply if a new candidate link has been found.

Envoy docs have links with unresolved anchors, this fix avoids collapsing the L3/L4 headers if not matching link for the anchor is found.

@Blendify Blendify requested a review from agjohnson Oct 4, 2017

@Blendify

This comment has been minimized.

Show comment
Hide comment
@Blendify

Blendify Oct 4, 2017

Contributor

Lgtm but I want to leave it up to @agjohnson because I do not do much Javascript.

Contributor

Blendify commented Oct 4, 2017

Lgtm but I want to leave it up to @agjohnson because I do not do much Javascript.

@mattklein123

This comment has been minimized.

Show comment
Hide comment
@mattklein123

mattklein123 Oct 12, 2017

@Blendify @agjohnson I'm fine going ahead and forking, however I'm a little confused about the "grunt" aspect of this. When I tried this patch without whatever extra stuff @petermd did it did not work for me. Can you advise so I can do the right thing in the fork? Thank you.

mattklein123 commented Oct 12, 2017

@Blendify @agjohnson I'm fine going ahead and forking, however I'm a little confused about the "grunt" aspect of this. When I tried this patch without whatever extra stuff @petermd did it did not work for me. Can you advise so I can do the right thing in the fork? Thank you.

@Blendify Blendify self-requested a review Oct 13, 2017

@Blendify

This comment has been minimized.

Show comment
Hide comment
@Blendify

Blendify Oct 13, 2017

Contributor

The correct thing to do is run grunt build the reason we say not to do that with the Pull Request is this auto-generates files which can be an issue with multiple pull requests. Although because it works for you and you have been using it for a while I will just merge it. However, I will ask for a favor, can you submit a new pr based off after the merge that just runs grunt build. I would do it but I only have a chromebook atm and wont be able to do it.

Contributor

Blendify commented Oct 13, 2017

The correct thing to do is run grunt build the reason we say not to do that with the Pull Request is this auto-generates files which can be an issue with multiple pull requests. Although because it works for you and you have been using it for a while I will just merge it. However, I will ask for a favor, can you submit a new pr based off after the merge that just runs grunt build. I would do it but I only have a chromebook atm and wont be able to do it.

@Blendify Blendify merged commit ee4d440 into rtfd:master Oct 13, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mattklein123

This comment has been minimized.

Show comment
Hide comment
@mattklein123

mattklein123 Oct 13, 2017

Thanks. @petermd any chance you can do the extra PR?

mattklein123 commented Oct 13, 2017

Thanks. @petermd any chance you can do the extra PR?

@petermd petermd deleted the petermd:avoid-auto-reset branch Oct 13, 2017

@petermd petermd referenced this pull request Oct 13, 2017

Merged

Follow-up grunt for #472 #476

Blendify added a commit that referenced this pull request Oct 15, 2017

Follow-up grunt for #472 (#476)
* grunt run

* regenerate theme css

travismiller added a commit to broco1974/couscous-template-readthedocs that referenced this pull request Dec 4, 2017

Merge commit '6c2302472fb2c61eec9b4be3a2515117fffbfac3' into rtfd
* commit '6c2302472fb2c61eec9b4be3a2515117fffbfac3': (253 commits)
  Add pygments_style to theme.conf
  Document new theme option
  Add option to layout.html
  Update theme.conf
  Apply clearfix on breadcrumbs
  Follow-up grunt for rtfd#472 (rtfd#476)
  Only change current if a matching link is found (rtfd#472)
  Add a couple of badge icons to readme (rtfd#471)
  Add Sphinx Framework for PyPi (rtfd#470)
  Fix error in setup entry points (rtfd#466)
  Added `.admonition` to the CSS (rtfd#462)
  Use explicit UTF8 encoding (rtfd#452)
  Add missing pygments css link
  Convert underscores to dashes.
  Reflect language in lang attribute.
  Replace master with v0.2.5 in README.rst
  Add missing dependency in dev setup: sphinxcontrib-httpdomain (rtfd#431)
  Finalized rtfd#418 (rtfd#433)
  Added a link to the Sphinx documentation about setuptools entry points
  Added setuptools entry point for Sphinx
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment