New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up grunt for #472 #476

Merged
merged 2 commits into from Oct 15, 2017

Conversation

Projects
None yet
3 participants
@petermd
Contributor

petermd commented Oct 13, 2017

Ran grunt build to re-generate the static js as per #472.

Please note: I did not

  • update any version number
  • include the re-generated css as there's a non-obvious diff (formatting of generated css?) in the css and css.map files but since the change has no CSS in it, I figured it was best to omit it

Let me know if thats ok

@Blendify

This comment has been minimized.

Show comment
Hide comment
@Blendify

Blendify Oct 13, 2017

Contributor

No, we need the css too from other PRs

Contributor

Blendify commented Oct 13, 2017

No, we need the css too from other PRs

@petermd

This comment has been minimized.

Show comment
Hide comment
@petermd

petermd Oct 14, 2017

Contributor

K, figured out my issue, had sass 3.5.2 installed which changes the default precision hence the large diffs. Triedbundle exec grunt build instead but the Gemfile.lock is pretty old so not sure there's a simple way to get a repeatable env? (if you have newer versions of the dependencies)

In any case, re-installing the required gems and re-running has picked up the CSS changes to theme.css - let me know if you need anything else.

Contributor

petermd commented Oct 14, 2017

K, figured out my issue, had sass 3.5.2 installed which changes the default precision hence the large diffs. Triedbundle exec grunt build instead but the Gemfile.lock is pretty old so not sure there's a simple way to get a repeatable env? (if you have newer versions of the dependencies)

In any case, re-installing the required gems and re-running has picked up the CSS changes to theme.css - let me know if you need anything else.

@Blendify Blendify merged commit 9d704f2 into rtfd:master Oct 15, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Blendify

This comment has been minimized.

Show comment
Hide comment
@Blendify

Blendify Oct 15, 2017

Contributor

Thanks

Contributor

Blendify commented Oct 15, 2017

Thanks

@mattklein123

This comment has been minimized.

Show comment
Hide comment
@mattklein123

mattklein123 commented Oct 16, 2017

Thank you @petermd !!! FYI envoyproxy/envoy#1860 💯

@petermd petermd deleted the petermd:avoid-auto-reset-grunt branch Oct 19, 2017

travismiller added a commit to broco1974/couscous-template-readthedocs that referenced this pull request Dec 4, 2017

Merge commit '6c2302472fb2c61eec9b4be3a2515117fffbfac3' into rtfd
* commit '6c2302472fb2c61eec9b4be3a2515117fffbfac3': (253 commits)
  Add pygments_style to theme.conf
  Document new theme option
  Add option to layout.html
  Update theme.conf
  Apply clearfix on breadcrumbs
  Follow-up grunt for rtfd#472 (rtfd#476)
  Only change current if a matching link is found (rtfd#472)
  Add a couple of badge icons to readme (rtfd#471)
  Add Sphinx Framework for PyPi (rtfd#470)
  Fix error in setup entry points (rtfd#466)
  Added `.admonition` to the CSS (rtfd#462)
  Use explicit UTF8 encoding (rtfd#452)
  Add missing pygments css link
  Convert underscores to dashes.
  Reflect language in lang attribute.
  Replace master with v0.2.5 in README.rst
  Add missing dependency in dev setup: sphinxcontrib-httpdomain (rtfd#431)
  Finalized rtfd#418 (rtfd#433)
  Added a link to the Sphinx documentation about setuptools entry points
  Added setuptools entry point for Sphinx
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment