Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
This looks good to me. I'd want to test it a little bit on various RTD builds to make sure it doesn't blow things up, but otherwise I'm +1 on the change.
LGTM assuming no breakages or slowdowns are experienced when testing with some larger projects on RTD.
Just throwing this out there, but how do you feel about making it a theme option to put the JS in the head? It is not needed, unless you're calling jQuery from inside rst like in #328. Putting JS in the head is risky for performance if large js libraries are included.
I'm not worried about performance, really. More about JS code people have written that depends on the current loading order, as well as the RTD specific code that we insert working with this loading order. I'll try and take a peek this week, but my week is pretty hectic.
referenced this pull request
Mar 28, 2018
added a commit
this pull request
Nov 4, 2018
-- Aaron Carlisle Project administrator for the Blender 3D Documentation Project Email: email@example.com Website: https://blendify.github.io