Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the name 'Dave Snider' with RTD #572

Merged
merged 5 commits into from Mar 19, 2018

Conversation

Projects
None yet
5 participants
@Blendify
Copy link
Contributor

Blendify commented Feb 12, 2018

No description provided.

@jessetan
Copy link
Contributor

jessetan left a comment

LGTM, note that RTD uses "Read the Docs, Inc" in setup.cfg and "Read the Docs, Inc & contributors" in LICENSE.
Perhaps @ericholscher has a preference how to refer to the RTD team/organization

@ericholscher

This comment has been minimized.

Copy link
Member

ericholscher commented Feb 14, 2018

I don't think we have a standard way of doing it, but probably should. I think "Read the Docs, Inc & contributors" is probably the most legally correct.

@Blendify Blendify requested review from ericholscher and agjohnson Feb 15, 2018

@ericholscher

This comment has been minimized.

Copy link
Member

ericholscher commented Feb 16, 2018

I do feel bad removing Dave's name from the explicit listing, since it was his creation originally. Is there a problem we're trying to solve with this?

@Blendify

This comment has been minimized.

Copy link
Contributor Author

Blendify commented Feb 16, 2018

Not specifically just that we are not giving hardly any attribution to current authors. I would be fine with add Dave to "Read the Docs, Inc & contributors"

@davidfischer

This comment has been minimized.

Copy link
Contributor

davidfischer commented Feb 20, 2018

Are we agreed on "Dave Snider, Read the Docs, Inc. & contributors"?

@ericholscher

This comment has been minimized.

Copy link
Member

ericholscher commented Mar 1, 2018

"Dave Snider, Read the Docs, Inc. & contributors" sounds good. Want to make sure Dave gets credit for a ton of work he did on the initial creation.

ericholscher and others added some commits Mar 7, 2018

@jessetan
Copy link
Contributor

jessetan left a comment

LGTM

@Blendify Blendify merged commit 3eebd9a into master Mar 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Blendify Blendify deleted the remove-snide branch Mar 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.