New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small visual improvement to captions in toctree #665

Merged
merged 7 commits into from Dec 4, 2018

Conversation

Projects
None yet
4 participants
@Blendify
Contributor

Blendify commented Aug 14, 2018

before
after

@davidfischer

This seems simple enough. It looks like it just reduces the horizontal padding on the captions in the toctree. That might help put an additional character or two in there.

@jessetan

This comment has been minimized.

Contributor

jessetan commented Sep 5, 2018

I'm -1 on reducing padding, makes it look cramped. I also just noticed that the captions are not exactly vertically aligned with the titles (captions slightly to the left).

If things need to stand out more, I'd rather increase the vertical padding

@agjohnson

This comment has been minimized.

Collaborator

agjohnson commented Sep 26, 2018

I'm probably -1 left margin removal too, it looks unbalanced to me. We had menu captions colored at one point, which i preferred -- example:

image

Also top margin increased for a little separation and to block sections together more.

@Blendify

This comment has been minimized.

Contributor

Blendify commented Sep 27, 2018

I like that better too, much more contrast is much nicer. I will update this patch soon to reflect that proposal.

Blendify added some commits Oct 1, 2018

Show resolved Hide resolved sass/_theme_variables.sass Outdated
Nav captions now have independent color
Co-Authored-By: Blendify <carlisle.b3d@gmail.com>
Show resolved Hide resolved sass/_theme_variables.sass Outdated

jessetan and others added some commits Nov 30, 2018

De saturate the bright blue captions
Co-Authored-By: Blendify <carlisle.b3d@gmail.com>

@Blendify Blendify merged commit 5b7d202 into master Dec 4, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Blendify Blendify deleted the Blendify/toctree-caption branch Dec 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment