New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set base font size on <html> #668

Merged
merged 2 commits into from Sep 17, 2018

Conversation

Projects
None yet
2 participants
@jessetan
Contributor

jessetan commented Sep 10, 2018

Most elements have their font size set to $base-font-size (14px), but some elements like lists and text in the sidebar inherit a font-size of 100% from <html>. This causes inconsistencies when viewed on a browser that sets a custom font size != 14px.

This PR sets the font size of <html> to $base-font-size so that everything has a uniform size, regardless of browser settings. It does not respect the browsers font size, which is bad for accessibility, but it does work with scaling by the browser.

Fixes #125

@jessetan jessetan requested review from davidfischer, agjohnson and Blendify Sep 10, 2018

@Blendify

Looks good.

@Blendify Blendify merged commit 3100436 into master Sep 17, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Blendify Blendify deleted the fix-125 branch Sep 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment