Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend DNSExceptions with human-readable messages #84

Closed
spacekpe opened this issue Dec 2, 2014 · 5 comments
Closed

Extend DNSExceptions with human-readable messages #84

spacekpe opened this issue Dec 2, 2014 · 5 comments

Comments

@spacekpe
Copy link

spacekpe commented Dec 2, 2014

Hello!

I wonder if you are open to accepting patches which would add human-readable messages to DNSException messsages.

The motivation is that currently dnspython users have to implement own logic which catches exceptions e.g. from resolver.query and translates them to meanigful messages for users. I had to do that myself several time.

I propose to add generic but explanatory text messages like 'YXDOMAIN from 192.0.2.1 when querying for x.y.z.example.' to DNSExceptions so dnspython users could simply do str(e) and be done with it.

Are you okay with the idea?

@rthalley
Copy link
Owner

rthalley commented Dec 2, 2014

On Dec 2, 2014, at 01:43, spacekpe notifications@github.com wrote:
Are you okay with the idea?

Yeah, that sounds useful, thanks!

/Bob

@spacekpe
Copy link
Author

spacekpe commented Feb 7, 2015

Bob, could you look at #85? Does it look okay? Could it be merged or should I fix something there?

@rthalley
Copy link
Owner

rthalley commented Feb 9, 2015

On Feb 7, 2015, at 09:11, spacekpe notifications@github.com wrote:

Bob, could you look at #85 #85? Does it look okay? Could it be merged or should I fix something there?

It's looking very nice; I've just been busy with other stuff. Will try to get it (and the python 3 branch) merged very soon.

Thanks!

/Bob

@spacekpe
Copy link
Author

@rthalley the pull request #85 contains Python 3 branch too, I hope it helps :-)

@spacekpe
Copy link
Author

Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants