Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete comment #873

Merged
merged 1 commit into from Jan 2, 2023
Merged

Remove obsolete comment #873

merged 1 commit into from Jan 2, 2023

Conversation

sblondon
Copy link
Contributor

According to the content of the comment (the reference to python3.6 as the future) and the PR #871, I guess the comment can be removed.

@rthalley
Copy link
Owner

I'll have to see if we still need that, as it was not a pre-3.6 statement, but rather trying to say "since 3.6...". Basically this code is suppressing a false warning. But, it may be that by only supporting 3.7 or later, it is not so confused.

@rthalley rthalley merged commit 6ba30da into rthalley:master Jan 2, 2023
rthalley pushed a commit that referenced this pull request Jan 2, 2023
(cherry picked from commit 6ba30da)
@sblondon sblondon deleted the remove-obsolete-comment branch January 2, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants