Skip to content
This repository has been archived by the owner on Mar 15, 2018. It is now read-only.

pyjwt upgrade #5

Merged
merged 2 commits into from Apr 20, 2015
Merged

pyjwt upgrade #5

merged 2 commits into from Apr 20, 2015

Conversation

andymckay
Copy link
Contributor

No description provided.

@andymckay
Copy link
Contributor Author

r? @rtilder

With: mozilla/zamboni#3015 and mozilla/marketplace-docs#57 I've gotten this far:

 invalid receipt: nbf 2015-04-02 11:38:48 > exp 2013-04-26 17:14:25 of signing cert; receipt: {u'product': {u'url': u'http://not-valid.com', u'storedata': u'id=1'}, u'iss': u'http://mp.dev', u'verify': u'http://mp.dev/not-valid', u'detail': u'http://mp.dev/not-valid', u'reissue': u'http://mp.dev/not-valid', u'user': {u'type': u'directed-identifier', u'value': u'something-not-valid'}, u'exp': 1427978328, u'iat': 1427974728, u'typ': u'purchase-receipt', u'nbf': 1427974728}
Raven is not configured (logging is disabled). Please see the documentation for more information.
Internal Server Error: /1.0/sign
Traceback (most recent call last):
  File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/django/core/handlers/base.py", line 111, in get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/django/views/generic/base.py", line 69, in view
    return self.dispatch(request, *args, **kwargs)
  File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/django/views/decorators/csrf.py", line 57, in wrapped_view
    return view_func(*args, **kwargs)
  File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/rest_framework/views.py", line 399, in dispatch
    response = self.handle_exception(exc)
  File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/rest_framework/views.py", line 396, in dispatch
    response = handler(request, *args, **kwargs)
  File "/srv/signing/signing_service/receipts/views.py", line 46, in post
    settings.SIGNING_SERVICE_RECEIPTS_ISSUERS)
  File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/websigning/validators.py", line 96, in valid_receipt
    receipt=receipt))
ReceiptConflict: nbf(not before) of receipt > exp(expires at) of signing cert

Do we need to do something with the cert?

@@ -225,7 +225,7 @@

# When True, it means Hawk authentication will be disabled everywhere.
# This is mainly just to get a speed-up while testing.
SKIP_HAWK_AUTH = False
SKIP_HAWK_AUTH = True
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is Hawk used anywhere? This might be apk-signer cruft.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rtilder is planning on using Hawk rather that OAuth for this bug: https://bugzilla.mozilla.org/show_bug.cgi?id=956363, first he wants to get the new server in and working, then start turning on Hawk. But that requires zamboni changes to support Hawk.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, then why did you want to skip hawk auth in the base settings? That turns off Hawk authentication by default.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well when its ready to work on we start turning it on.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yeah, heh, good idea

@rtilder
Copy link
Contributor

rtilder commented Apr 20, 2015

Whoa. I thought I merged this weeks ago.

rtilder added a commit that referenced this pull request Apr 20, 2015
@rtilder rtilder merged commit d6abdac into mozilla:master Apr 20, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants